Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query scheduler to "Read Resources" mixin dashboard #6028

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Apr 26, 2022

This component has been around for a while but has not been added to the
loki-mixin yet.

Signed-off-by: Christian Haudum christian.haudum@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

This component has been around for a while but has not been added to the
loki-mixin yet.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum marked this pull request as ready for review April 26, 2022 14:57
@chaudum chaudum requested a review from a team as a code owner April 26, 2022 14:57
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

Adding a screenshot or public preview link would be helpful to review PR(s) like this IMHO :)

@chaudum
Copy link
Contributor Author

chaudum commented Apr 26, 2022

Adding a screenshot or public preview link would be helpful to review PR(s) like this IMHO :)

Agree. Let me install the dashboards locally.

@chaudum
Copy link
Contributor Author

chaudum commented Apr 27, 2022

@kavirajk Added a screenshot to the PR description.

@chaudum chaudum requested a review from owen-d April 27, 2022 15:24
@cyriltovena
Copy link
Contributor

Can we stack CPU and memory graph or that is too much ?

@kavirajk
Copy link
Contributor

@kavirajk Added a screenshot to the PR description.

I don't see it yet. I see it on the other PR though :) https://github.com/grafana/deployment_tools/pull/30245. Feel free to go ahead on merge. It's a non blocker.

@chaudum
Copy link
Contributor Author

chaudum commented Apr 28, 2022

@kavirajk 🤦 I'm pretty sure I posted it already. Here we go ...
2022-04-27_10-59

@kavirajk kavirajk merged commit e2cde40 into main Apr 29, 2022
@kavirajk kavirajk deleted the chaudum/loki-mixin-add-query-scheduler branch April 29, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants