chore(query-scheduler) Remove nosiy "inflight" requests log entries #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have enough metrics now (queue time, queue length and metrics.go statistics) that makes these log entries obselete. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
dannykopping
reviewed
May 2, 2022
No. not per tenant basis. ( I tried once, but reverted because of cardinality explosion) The reason to remove is mainly it's noisy (two log entries per every request) and also we pay quite a bit for this (heard it from @slim-bean). |
Cool, I'm happy to defer to Ed's LGTM here. |
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have enough metrics now (queue time, queue length and metrics.go statistics)
that makes these log entries obselete.
Signed-off-by: Kaviraj kavirajkanagaraj@gmail.com
Which issue(s) this PR fixes:
Fixes #NA
Special notes for your reviewer:
Quickly checked internal and external mixins to verify it's not used in any dashboards or alerts.
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md