Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not increment sync operation count metric on per index set #6109

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Do not increment index sync operation count metric from index set since we already track it on the overall sync operation in table manager here.

This would also fix unexpected increases in failure counts due to stale index list cache which we handle already by checking if the error is errIndexListCacheTooStale and retry the sync.

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner May 6, 2022 01:23
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants