Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip empty object key returned by some s3 compatible storage while listing boltdb-shipper index #6123

Merged
merged 1 commit into from
May 17, 2022
Merged

skip empty object key returned by some s3 compatible storage while listing boltdb-shipper index #6123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/storage/stores/shipper/storage/cached_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ func (c *cachedObjectClient) buildCache(ctx context.Context, forceRefresh bool)
c.tableNames = []client.StorageCommonPrefix{}

for _, object := range objects {
// The s3 client can also return the directory itself in the ListObjects.
if object.Key == "" {
continue
}

ss := strings.Split(object.Key, delimiter)
if len(ss) < 2 || len(ss) > 3 {
return fmt.Errorf("invalid key: %s", object.Key)
Expand Down