Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query-scheduler: Now proper support for querier_forget_delay #6174

Merged
merged 3 commits into from
May 17, 2022
Merged

query-scheduler: Now proper support for querier_forget_delay #6174

merged 3 commits into from
May 17, 2022

Conversation

kavirajk
Copy link
Contributor

Signed-off-by: Kaviraj kavirajkanagaraj@gmail.com

What this PR does / why we need it:
Since now shuffle sharding is supported on the query-path in Loki,
it makes sense to enable this config.

Which issue(s) this PR fixes:
Fixes #NA

Special notes for your reviewer:

Related #6173

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@kavirajk
query-scheduler: Now proper support for querier_forget_delay
3b7d820 
Since now shuffle sharding is supported on the `query-path` in Loki,
it makes sense to enable this config.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
@kavirajk kavirajk requested review from KMiller-Grafana and a team as code owners May 17, 2022 09:24
simonswine
simonswine reviewed May 17, 2022
View reviewed changes
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
docs/sources/configuration/_index.md Outdated Show resolved Hide resolved
kavirajk and others added 2 commits May 17, 2022 11:28
@kavirajk @simonswine
Update pkg/scheduler/scheduler.go
af8258f 
Co-authored-by: Christian Simon <simon@swine.de>
@kavirajk @simonswine
Update docs/sources/configuration/_index.md
3dcb4c1 
Co-authored-by: Christian Simon <simon@swine.de>
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

sandeepsukhani
sandeepsukhani approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0.3%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

simonswine
simonswine approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavirajk kavirajk merged commit e3a43c6 into main May 17, 2022
@kavirajk kavirajk deleted the kavirajk/remove-querier-delay-hardcording branch May 17, 2022 10:00
This was referenced Jun 28, 2022
Closed
Draft
@osg-grafana osg-grafana added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed area/docs labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

@sandeepsukhani sandeepsukhani sandeepsukhani approved these changes

@KMiller-Grafana KMiller-Grafana Awaiting requested review from KMiller-Grafana

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kavirajk @grafanabot @simonswine @sandeepsukhani @chaudum @osg-grafana