-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make boltdb-shipper use the generic indexshipper for managing index in object storage #6226
make boltdb-shipper use the generic indexshipper for managing index in object storage #6226
Conversation
b16502f
to
a849898
Compare
… index on object storage
a849898
to
39f2c6a
Compare
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
- storage -0.2%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
- storage -0.2%
+ chunkenc 0%
- logql -0.5%
+ loki 0% |
What this PR does / why we need it:
Make
boltdb-shipper
use the genericindexshipper
for managing the index on object storage.I have also moved index gateway client and its config to
indexshipper
since it is supposed to be used withtsdb
as well.Special notes for your reviewer:
Since this PR was getting too big, I will open a follow-up PR for the following changes:
pkg/storage/stores/shipper/index
topkg/storage/stores/shipper/index/writes
package.boltdb-shipper
metrics toindexshipper
and make it reusable fortsdb
.pkg/storage/stores/shipper
topkg/storage/stores/boltdbshipper
.Checklist