Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonnet tools to build image #6255

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

pracucci
Copy link
Contributor

What this PR does / why we need it:
In #6254 I'm proposing to publish a compiled version of the mixin. To make it run in CI, we need to add some jsonnet tools to build image, which is what I'm doing in this PR. I've bumped the build image minor version (from 0.20 to 0.21) because I guess you follow semver.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Changes have been tested in #6254

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@kavirajk kavirajk enabled auto-merge (squash) May 26, 2022 12:50
@kavirajk kavirajk merged commit 58718a5 into main May 26, 2022
@kavirajk kavirajk deleted the add-jsonnet-tools-to-build-image branch May 26, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants