Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promtail: Allow docker_sd_config to handle log lines longer than 64k #6256

Merged
merged 1 commit into from
Jun 3, 2022
Merged

promtail: Allow docker_sd_config to handle log lines longer than 64k #6256

merged 1 commit into from
Jun 3, 2022

Commits on May 27, 2022

  1. fix: allow promtail docker_sd_config to handle long log lines 

    In promtail's docker_sd_config, parsing of a container's
logs would fail if any log line was over 64k bytes in length.
This is because bufio.Scanner uses a 64k buffer by default.
Since there doesn't appear to be a way to elegantly catch
`bufio.ErrTooLong` and carry on, the parsing approach was changed
to bufio.Reader which can handle lines of arbitrary length.
    @srstsavage
    srstsavage committed May 27, 2022
    Configuration menu
    Copy the full SHA
    4e773fc View commit details
    Browse the repository at this point in the history