[logql] don't try to execute a modified function that is not allowed by the AST #6346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original panic was not useful, the change to the
clone
function and it's usage will ensure that in future cases we at least get an error message along with the panic stack trace. This PR also calls thevalidate
function on the modified range query to ensure it's still allowed. In the case of the panic we saw,unwrap
is not allowed withcount_over_time
, when in the original query we hadrate
withunwrap
which is allowed.