Deletion: use correct counter when deleting lines #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
pkg/storage/stores/shipper/compactor/deletion/delete_requests_manager.go
Show resolved
Hide resolved
sandeepsukhani
approved these changes
Jun 13, 2022
pkg/storage/stores/shipper/compactor/deletion/delete_requests_manager.go
Show resolved
Hide resolved
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
MichelHollands
force-pushed
the
fix_metric_name_for_deleted_lines
branch
from
11bfa00
to
2567302
Compare
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
MasslessParticle
approved these changes
Jun 13, 2022
4 tasks
grafanabot
pushed a commit
that referenced
this pull request
Jun 23, 2022
Signed-off-by: Michel Hollands <michel.hollands@grafana.com> (cherry picked from commit 671afe6)
MichelHollands
added a commit
that referenced
this pull request
Jun 23, 2022
grafanabot
added a commit
that referenced
this pull request
Jun 24, 2022
vlad-diachenko
pushed a commit
that referenced
this pull request
Jun 24, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
An incorrect counter was used when deleting lines. A test to check the counter is added as well.
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.mdSigned-off-by: Michel Hollands michel.hollands@grafana.com