[release-2.6.x] Fix panic in instant query splitting when using unwrapped rate #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix panic in instant query splitting when using unwrapped rate
The range aggregation `rate()` supports both log ranges and unwrapped
ranges, e.g.
`rate({app="foo"} [$__interval])`
and
`rate({app="foo"} | unwrap bar [$__interval])`
Since `rate()` was split into multiple `count_over_time()` over total
duration, but `count_over_time()` does not support `unwrap`, unwrapped
rate queries caused panics.
This fix changes the splitting of `rate({app="foo"} | unwrap bar [$__interval]`
into multiple `sum_over_time()` over total duration.
Fixes #6344
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
* Add tests
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
* Integrate review feedback
Co-authored-by: Susana Ferreira <susana.ferreira@grafana.com>
Co-authored-by: Susana Ferreira <susana.ferreira@grafana.com>
(cherry picked from commit 798677a)
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0.4%
+ distributor 0%
- querier -0.3%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
- logql -0.1%
- loki -2.2% |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0.4%
+ distributor 0%
- querier -0.3%
- querier/queryrange -0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
- logql -0.1%
- loki -2.2% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 798677a from #6348