fix(Makefile): allow setting GOARCH #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overwrite GOARCH for the `assets` task to prevent it from failing
|
Assigned to @slim-bean , he has experiences with the build system. |
|
Redundant, see #753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make cross compiling easier, the
Makefileshould allow to setGOOSandGOARCH.However, the
assetstask is generating a binary that has to be executed locally. If the two environment variables would be left as they for this target, it would fail because of anexec-format error, as the compiled binary is not for the Host OS anymore.To prevent this
GOARCHandGOOSare overwritten withGOHOSTARCHandGOHOSTOSrespectively.This also simplifies building for
arm(64), as requested by #653