Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loki): panic on missing config #720

Merged
merged 3 commits into from
Jul 8, 2019
Merged

fix(loki): panic on missing config #720

merged 3 commits into from
Jul 8, 2019

Commits on Jul 6, 2019

  1. fix(loki): pass missing config error to user 

    Missing config errors are handled at the library level. Our own check mitigated
this and causes loki to SEGFAULT later on
    @sh0rez
    sh0rez committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    b2744fc View commit details
    Browse the repository at this point in the history

  2. feat(loki): default config file in container 

    The container provides a default config file. Use it by default
    @sh0rez
    sh0rez committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    069580f View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. Revert "fix(loki): pass missing config error to user" 

    This reverts commit b2744fc, because loki it
assumed loki was incapable of running without config, which is not the case.
    @sh0rez
    sh0rez committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    e9bdc1f View commit details
    Browse the repository at this point in the history