Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-promtail): add bearer token support #7333

Merged
merged 2 commits into from
Oct 5, 2022
Merged

feat(lambda-promtail): add bearer token support #7333

merged 2 commits into from
Oct 5, 2022

Conversation

bt909
Copy link
Contributor

@bt909 bt909 commented Oct 5, 2022

What this PR does / why we need it:
It adds bearer token support for lambda-promtail, as it supports only http basic auth.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

Squashed commit of the following:

commit c2a43325b4ffe7f35e37b510d5a2df6555f4841f
Author: Thomas Belian <thomas.belian@bt909.de>
Date:   Fri Sep 30 13:41:40 2022 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tools/lambda-promtail/Dockerfile

commit dc17f753f828d20f45a496dccad67167279b6b6c
Author: Kirchen99 <latias_latios@126.com>
Date:   Fri Sep 30 11:37:10 2022 +0200

    mob next [ci-skip] [ci skip] [skip ci]

commit 602958b375f9beb6a40ba62e8bea2aa467ed6952
Author: Michael Zinovjev <mike.t.c.b@gmail.com>
Date:   Fri Sep 30 11:14:43 2022 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tools/lambda-promtail/template.yaml

commit 441b56a512dde9a6816174d447e7e80c032fb393
Author: Kirchen99 <latias_latios@126.com>
Date:   Fri Sep 30 11:05:41 2022 +0200

    mob next [ci-skip] [ci skip] [skip ci]

commit 966e7ab1952bf25fdd4d62f3dd6d325d8edb87ed
Author: Thomas Belian <thomas.belian@bt909.de>
Date:   Fri Sep 30 10:57:04 2022 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tools/lambda-promtail/lambda-promtail/main.go
Co-authored-by: Kirchen99 <latias_latios@126.com>
Co-authored-by: Michael Zinovjev <mike.t.c.b@gmail.com>

Signed-off-by: Thomas Belian <thomas.belian@bt909.de>
Signed-off-by: Thomas Belian <thomas.belian@bt909.de>
@bt909 bt909 requested a review from a team as a code owner October 5, 2022 06:23
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2022

CLA assistant check
All committers have signed the CLA.

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit b795672 into grafana:main Oct 5, 2022
@bt909 bt909 deleted the bearer-token-support branch October 5, 2022 12:12
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
It adds bearer token support for lambda-promtail, as it supports only
http basic auth.

Signed-off-by: Thomas Belian <thomas.belian@bt909.de>
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
It adds bearer token support for lambda-promtail, as it supports only
http basic auth.

Signed-off-by: Thomas Belian <thomas.belian@bt909.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants