Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Promtail and Heroku blogpost files to examples/ #7347

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

thepalbi
Copy link
Contributor

@thepalbi thepalbi commented Oct 5, 2022

What this PR does / why we need it:
Some weeks ago a blogpost was written on how to configure Promtail to receive logs from Heroku, and write them to Loki. This blogpost contains some configuration snippets like a Promtail config, a Dockerfile, etc. It's been mentioned is annoying to copy and paste the snippets from there, so this PR adds this snippets under the examples/ folder, so that they are easily readable and iterated if necessary.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@thepalbi thepalbi requested a review from a team as a code owner October 5, 2022 15:59
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dannykopping dannykopping merged commit cd919f7 into main Oct 6, 2022
@dannykopping dannykopping deleted the pablo/add-heroku-blogpost-sources branch October 6, 2022 06:56
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants