Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3: add support for s3 session token #8474

Merged
merged 1 commit into from
Feb 28, 2023
Merged

S3: add support for s3 session token #8474

merged 1 commit into from
Feb 28, 2023

Conversation

farodin91
Copy link
Contributor

@farodin91 farodin91 commented Feb 9, 2023 •
edited by chaudum
Loading

What this PR does / why we need it:

We want to automate the access account rotation. This is that easy at moment with service accounts in minio. Our currently life time of tokens is 3 months with minio sts works this fine.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@farodin91 farodin91 requested review from JStickler and a team as code owners February 9, 2023 07:28
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Feb 9, 2023
@farodin91 farodin91 force-pushed the add-support-for-s3-session-token branch from bdc3300 to f4d6112 Compare February 9, 2023 07:29
@farodin91 farodin91 changed the title add support for s3 session token S3: add support for s3 session token Feb 9, 2023
JStickler
JStickler approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Doc squad] Documentation LGTM.

@farodin91 farodin91 force-pushed the add-support-for-s3-session-token branch from f4d6112 to 2ca68cc Compare February 17, 2023 09:40
@farodin91 farodin91 force-pushed the add-support-for-s3-session-token branch from 2ca68cc to 3a63358 Compare February 21, 2023 07:13
@farodin91
Copy link
Contributor Author

@vlad-diachenko Would you like to review my commit?

chaudum
chaudum reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @farodin91
Could you explain a bit why you would want to use short-lived, temporary security credentials for a long running application?

Is it for use with LogCLI?

@farodin91
Copy link
Contributor Author

Hey @chaudum, We want to automate the access account rotation. This is that easy at moment with service accounts in minio. Our currently life time of tokens is 3 months with minio sts works this fine.

chaudum
chaudum reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Small nit regarding the changelog entry.

CHANGELOG.md Outdated Show resolved Hide resolved
@chaudum
Copy link
Contributor

chaudum commented Feb 27, 2023

Hey @chaudum, We want to automate the access account rotation. This is that easy at moment with service accounts in minio. Our currently life time of tokens is 3 months with minio sts works this fine.

I updated the PR description with your information.

@farodin91
add support for s3 session token
408a054 
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
@farodin91 farodin91 force-pushed the add-support-for-s3-session-token branch from 3a63358 to 408a054 Compare February 27, 2023 11:15
@farodin91
Copy link
Contributor Author

@chaudum rebased

@chaudum chaudum merged commit 84c5e20 into grafana:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum left review comments

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farodin91 @CLAassistant @chaudum @JStickler