chore(packaging): wrong executable format #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
approved these changes
Aug 12, 2019
slim-bean
reviewed
Aug 12, 2019
slim-bean
reviewed
Aug 12, 2019
|
was a little quick on the approve button! check my comments before merging |
rfratto
requested changes
Aug 12, 2019
Due to an invalid usage of bash, the binary was always built for amd64. This fixes that and builds the correct one.
sh0rez
force-pushed
the
multiarch-exec-format-error
branch
from
e501d75
to
2feb646
Compare
|
thanks, missed that |
rfratto
approved these changes
Aug 12, 2019
|
@sh0rez Build is failed for promtail arm64 |
|
Thanks, CircleCI is kinda quirky, retriggering until it suceeds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an invalid usage of bash, the binary was always built for amd64.
This fixes that and builds the correct one.
Fixes #885