-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promtail: Break on iterate journal failure #9155
Promtail: Break on iterate journal failure #9155
Conversation
a3ab61e
to
a6be5af
Compare
@dannykopping Would you like to review? I have no idea why drone is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you please add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farodin91 on second thought, we don't need a test here. Thank you
@dannykopping Will this be backported? |
Sure 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9155-to-release-2.8.x origin/release-2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c4048a3adffc4b13957d0b3f41381277b391c56f
# Push it to GitHub
git push --set-upstream origin backport-9155-to-release-2.8.x
git switch main
# Remove the local backport branch
git branch -D backport-9155-to-release-2.8.x Then, create a pull request where the |
(cherry picked from commit c4048a3)
@farodin91 done: #9403 |
What this PR does / why we need it:
https://github.com/coreos/go-systemd/blob/main/sdjournal/journal.go#L583 origin
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updateddocs/sources/upgrading/_index.md