Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retention doc tsdb support of compactor #9397

Merged
merged 1 commit into from
May 4, 2023
Merged

Update retention doc tsdb support of compactor #9397

merged 1 commit into from
May 4, 2023

Conversation

alainpham
Copy link
Contributor

@alainpham alainpham commented May 4, 2023 •
edited
Loading

compactor now also supports tsdb in addition to boltdb-schipper

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@alainpham
Update retention doc tsdb support of compactor
2102df9 
compactor now also supports tsdb in addition to boltdb-schipper
@alainpham alainpham requested a review from JStickler as a code owner May 4, 2023 14:21
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 4, 2023
JStickler
JStickler approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] LGTM

owen-d
owen-d approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@owen-d owen-d merged commit c1052d7 into main May 4, 2023
@owen-d owen-d deleted the alainpham-patch-1 branch May 4, 2023 15:26
aminesnow pushed a commit to aminesnow/loki that referenced this pull request May 4, 2023
@alainpham
Update retention doc tsdb support of compactor (grafana#9397)
0cd3889 
compactor now also supports tsdb in addition to boltdb-schipper

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes #<issue number>

**Special notes for your reviewer**:

**Checklist**
- [ ] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
@roelarents roelarents mentioned this pull request Aug 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alainpham @JStickler @owen-d