helm: release a new helm charts to use k8s service for discover query-scheduler replicas #9477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
trevorwhitney
approved these changes
May 18, 2023
| @@ -207,6 +207,16 @@ loki: | |||
| index_gateway: | |||
| {{- tpl (. | toYaml) $ | nindent 4 }} | |||
| {{- end }} | |||
|
|
|||
There was a problem hiding this comment.
Can we add a TODO or some other note here to remove this section once we bump the Loki version?
There was a problem hiding this comment.
What do you think about continuing to use k8s service for service discovery? I am going to merge this PR, for now, to get the fix out. I will take care of the feedback in PR #9471 if you think we should move back to ring-based service discovery.
| @@ -302,6 +312,10 @@ loki: | |||
| # -- Optional index gateway configuration | |||
| index_gateway: | |||
| mode: ring | |||
| frontend: | |||
There was a problem hiding this comment.
Alternatively we could add the comment here to set these to empty objects when we bump the Loki version.
rgarcia6520
pushed a commit
to rgarcia6520/grafana-loki
that referenced
this pull request
May 26, 2023
…-scheduler replicas (grafana#9477) **What this PR does / why we need it**: Currently, we have a bug in our code when running Loki in SSD mode and using the ring for query-scheduler discovery. It causes queries to not be distributed to all the available read pods. I have explained the issue in detail in [the PR which fixes the code](grafana#9471). Since this bug causes a major query performance impact and code release might take time, in this PR we are doing a new helm release which fixes the issue by using the k8s service for discovering `query-scheduler` replicas. **Which issue(s) this PR fixes**: Fixes grafana#9195
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, we have a bug in our code when running Loki in SSD mode and using the ring for query-scheduler discovery. It causes queries to not be distributed to all the available read pods. I have explained the issue in detail in the PR which fixes the code.
Since this bug causes a major query performance impact and code release might take time, in this PR we are doing a new helm release which fixes the issue by using the k8s service for discovering
query-schedulerreplicas.Which issue(s) this PR fixes:
Fixes #9195