Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also get logs and metrics for agents #25

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Mar 27, 2024

The agent will now scrape metrics and gather logs for it's own pods. Tested in k3d while sending to the cloud. Logs and metrics for the agent pods are there now.

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Copy link

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't that be a change in behavior for existing metamonitoring users? (do we have people already using it? not sure)

@MichelHollands
Copy link
Contributor Author

won't that be a change in behavior for existing metamonitoring users? (do we have people already using it? not sure)

As far as I know nobody is using it yet. Also note that this is just additional logs and metrics. The current version doesn't collect these. Lastly this was explicitly requested by one of our SMEs. It helps us troubleshoot the chart itself.

@MichelHollands MichelHollands merged commit e3542e4 into main Mar 27, 2024
2 checks passed
@MichelHollands MichelHollands deleted the scrape_grafana_agents branch April 10, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants