This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1745 from bloomberg/unique
Add unique processing function
- Loading branch information
Showing
4 changed files
with
207 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package expr | ||
|
||
import ( | ||
"github.com/grafana/metrictank/api/models" | ||
) | ||
|
||
type FuncUnique struct { | ||
in []GraphiteFunc | ||
} | ||
|
||
func NewUnique() GraphiteFunc { | ||
return &FuncUnique{} | ||
} | ||
|
||
func (s *FuncUnique) Signature() ([]Arg, []Arg) { | ||
return []Arg{ | ||
ArgSeriesLists{val: &s.in}}, []Arg{ArgSeriesList{}} | ||
} | ||
|
||
func (s *FuncUnique) Context(context Context) Context { | ||
return context | ||
} | ||
|
||
func (s *FuncUnique) Exec(dataMap DataMap) ([]models.Series, error) { | ||
series, _, err := consumeFuncs(dataMap, s.in) | ||
if err != nil { | ||
return nil, err | ||
} | ||
seenNames := make(map[string]bool) | ||
var uniqueSeries []models.Series | ||
for _, serie := range series { | ||
if _, ok := seenNames[serie.Target]; !ok { | ||
seenNames[serie.Target] = true | ||
uniqueSeries = append(uniqueSeries, serie) | ||
} | ||
} | ||
return uniqueSeries, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,167 @@ | ||
package expr | ||
|
||
import ( | ||
"strconv" | ||
"testing" | ||
|
||
"github.com/grafana/metrictank/api/models" | ||
"github.com/grafana/metrictank/schema" | ||
"github.com/grafana/metrictank/test" | ||
) | ||
|
||
func getNewUnique(in [][]models.Series) *FuncUnique { | ||
f := NewUnique() | ||
s := f.(*FuncUnique) | ||
for i := range in { | ||
s.in = append(s.in, NewMock(in[i])) | ||
} | ||
return s | ||
} | ||
|
||
func TestUnique(t *testing.T) { | ||
f := getNewUnique([][]models.Series{ | ||
{ | ||
{ | ||
Interval: 10, | ||
QueryPatt: "foo.a", | ||
Target: "foo.a", | ||
Datapoints: getCopy(a), | ||
}, | ||
{ | ||
Interval: 100, | ||
QueryPatt: "foo.b", | ||
Target: "foo.b", | ||
Datapoints: getCopy(b), | ||
}, | ||
}, | ||
{ | ||
{ | ||
Interval: 10, | ||
QueryPatt: "bar.b", | ||
Target: "bar.b", | ||
Datapoints: getCopy(b), | ||
}, | ||
}, | ||
{ | ||
{ | ||
Interval: 10, | ||
QueryPatt: "foo.a", | ||
Target: "foo.a", | ||
Datapoints: getCopy(a), | ||
}, | ||
{ | ||
Interval: 10, | ||
QueryPatt: "bar.*", | ||
Target: "bar.b", | ||
Datapoints: getCopy(b), | ||
}, | ||
{ | ||
Interval: 100, | ||
QueryPatt: "bar.*", | ||
Target: "bar.d", | ||
Datapoints: getCopy(d), | ||
}, | ||
{ | ||
Interval: 10, | ||
QueryPatt: "foo.a", | ||
Target: "foo.a", | ||
Datapoints: getCopy(a), | ||
}, | ||
}, | ||
}, | ||
) | ||
|
||
out := []models.Series{ | ||
{ | ||
Interval: 10, | ||
QueryPatt: "foo.a", | ||
Target: "foo.a", | ||
Datapoints: getCopy(a), | ||
}, | ||
{ | ||
Interval: 100, | ||
QueryPatt: "foo.b", | ||
Target: "foo.b", | ||
Datapoints: getCopy(b), | ||
}, | ||
{ | ||
Interval: 10, | ||
QueryPatt: "bar.b", | ||
Target: "bar.b", | ||
Datapoints: getCopy(b), | ||
}, | ||
{ | ||
Interval: 100, | ||
QueryPatt: "bar.*", | ||
Target: "bar.d", | ||
Datapoints: getCopy(d), | ||
}, | ||
} | ||
|
||
got, err := f.Exec(make(map[Req][]models.Series)) | ||
if err := equalOutput(out, got, nil, err); err != nil { | ||
t.Fatal(err) | ||
} | ||
} | ||
|
||
func BenchmarkUnique10k_1NoNulls(b *testing.B) { | ||
benchmarkUnique(b, 1, test.RandFloats10k, test.RandFloats10k) | ||
} | ||
func BenchmarkUnique10k_10NoNulls(b *testing.B) { | ||
benchmarkUnique(b, 10, test.RandFloats10k, test.RandFloats10k) | ||
} | ||
func BenchmarkUnique10k_100NoNulls(b *testing.B) { | ||
benchmarkUnique(b, 100, test.RandFloats10k, test.RandFloats10k) | ||
} | ||
func BenchmarkUnique10k_1000NoNulls(b *testing.B) { | ||
benchmarkUnique(b, 1000, test.RandFloats10k, test.RandFloats10k) | ||
} | ||
func BenchmarkUnique10k_1SomeSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 1, test.RandFloats10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_10SomeSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 10, test.RandFloats10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_100SomeSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 100, test.RandFloats10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_1000SomeSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 1000, test.RandFloats10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_1AllSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 1, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_10AllSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 10, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_100AllSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 100, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k) | ||
} | ||
func BenchmarkUnique10k_1000AllSeriesHalfNulls(b *testing.B) { | ||
benchmarkUnique(b, 1000, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k) | ||
} | ||
|
||
func benchmarkUnique(b *testing.B, numSeries int, fn0, fn1 func() []schema.Point) { | ||
var input []models.Series | ||
for i := 0; i < numSeries; i++ { | ||
series := models.Series{ | ||
QueryPatt: strconv.Itoa(i), | ||
} | ||
if i%2 == 0 { | ||
series.Datapoints = fn0() | ||
} else { | ||
series.Datapoints = fn1() | ||
} | ||
input = append(input, series) | ||
} | ||
b.ResetTimer() | ||
for i := 0; i < b.N; i++ { | ||
f := NewUnique() | ||
f.(*FuncUnique).in = append(f.(*FuncUnique).in, NewMock(input)) | ||
got, err := f.Exec(make(map[Req][]models.Series)) | ||
if err != nil { | ||
b.Fatalf("%s", err) | ||
} | ||
results = got | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters