Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

simplify TimeLimiter, fixing its tests #1088

Merged
merged 5 commits into from
Oct 23, 2018
Merged

simplify TimeLimiter, fixing its tests #1088

merged 5 commits into from
Oct 23, 2018

Commits on Oct 10, 2018

  1. simplify TimeLimiter, fixing its tests

    * previous implementation was a bit hastily implemented and
      much more complicated than needed:
      trying to support concurrency but not doing it well, while
      we don't actually need any of it.
    * unit testing was very flakey, in particular in circleCI there's
      lots of timing inaccuracy leading to broken tests
    * it was inaccurate, for shortlived operations it would be negligible
      but for longer operations it is not. While our use case operations
      should be short, it is nice to be able to fix this while we're at it.
    
    So now we simplify the design a lot, basically reduce it to
    a non-concurrent accounting structure, removing all channels,
    goroutines and context, making the accounting more correct
    and the testing more robust.
    Dieterbe committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    8dab8f0 View commit details
    Browse the repository at this point in the history
  2. fix tests, cleanup

    Dieterbe committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    25f8522 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. clarify

    Dieterbe committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    827b74e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11b6a85 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. validation

    Dieterbe committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    d2552ec View commit details
    Browse the repository at this point in the history