Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

make Find cache optional #1285

Merged
merged 2 commits into from
Apr 17, 2019
Merged

make Find cache optional #1285

merged 2 commits into from
Apr 17, 2019

Conversation

Dieterbe
Copy link
Contributor

No description provided.

@Dieterbe Dieterbe requested a review from woodsaj April 16, 2019 07:42
@Dieterbe Dieterbe force-pushed the find-cache-optional branch 2 times, most recently from 6d74a80 to f3cbbb5 Compare April 16, 2019 07:56
@woodsaj
Copy link
Member

woodsaj commented Apr 16, 2019

wouldnt it be easier to just disable the findCache if find-cache-size is set to 0?

@Dieterbe
Copy link
Contributor Author

hmm yes. will update

@Dieterbe
Copy link
Contributor Author

PTAL

Copy link
Member

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe Dieterbe merged commit 45405aa into master Apr 17, 2019
@woodsaj woodsaj deleted the find-cache-optional branch July 2, 2019 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants