Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Kafka notifier: do not wait until timeout when there is no backlog to process, ie. no message in the partition queue #1315

Merged
merged 3 commits into from
May 23, 2019

Commits on May 17, 2019

  1. Kafka notifier: do not wait until timeout when there is no backlog to…

    … process, ie. no message in the partition queue
    fkaleo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    a1cf12d View commit details
    Browse the repository at this point in the history
  2. Rationalised NotifierKafka's backlog processing:

    - keep bootTimeOffsets local to consumePartition and renamed it to lastAvailableOffsetAtStartup
    - at startup invoke GetOffset() to retrieve the explicit index in all cases ('oldest', 'newest', timestamp)
    - factored duplicated code into updateProcessBacklog() and updateMetrics()
    - when consumePartition() starts, check if backlog has been processed; fixes all cases of backlog processing stuck when no messages need to be received.
    
    Note: partitionLagMetric was previously set to GetOffset(..., OffsetNewest) - msg.Offset and is now set to GetOffset(..., OffsetNewest) - msg.Offset - 1. Other metrics remained unchanged.
    fkaleo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    c451e62 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. Configuration menu
    Copy the full SHA
    a211433 View commit details
    Browse the repository at this point in the history