This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Rename Error interface method to avoid collisions with gocql #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was leading to nonsense HTTP status codes as seen in #1678.
|
I did not think about this approach but I love it !! |
|
thanks for reviewing Sean :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was leading to nonsense HTTP status codes as seen in #1678.
Also rolls back the mitigations added in #987 now that a permanent fix is in place.
This is the super low effort approach to fixing #1678... If we feel strongly about the old interface names, we could probably make more targeted changes at the Cassandra call sites.