This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Fix NormalizeTo bug: prepend correct amount of points to pre-canonicalize series #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
approved these changes
Apr 30, 2020
Dieterbe
changed the title
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1812
The basic issue here is that we weren't prepending enough NaN to fill out a series before calling consolidate. For the example in the test we had timestamps:
[ 45, 60, 75, 90, 105, 135 ]that we want to normalize to 60 second data. This means turning 4 points into 1. For consolidate to act on the proper time boundaries 15-60 and 75-105, we need to pad extra timestamps in the front to make[ 15, 30, 45, 60, 75, 90, 105, 135 ]Unfortunately, the current code uses the output interval (60) not the input interval (15) as the step, so it would only ever prepend 0 or 1 timestamps.