This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
assure that consolidation.Consolidate always gets a non-None consolidator #1843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1814
Note that "special functions" resetting the consolidator is part of the current design, as described in
https://github.com/grafana/metrictank/blob/master/devdocs/expr.md, section about
consolidateBy
arguably, this design needs to be revised completely as proposed in #1490, or until we do, special functions should set the consolidator to average rather than None, which would be more robust, and depending on how you interpret the spec, implement it more accurately, rather than having to add these checks after functions have run.
But for now, this does the job.