Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Make summarize() output canonical in the !alignToFrom case #1849

Merged
merged 7 commits into from
Jun 17, 2020
Merged

Make summarize() output canonical in the !alignToFrom case #1849

merged 7 commits into from
Jun 17, 2020

Commits on Jun 15, 2020

  1. document consolidation in response path + refine normalization naming 

    disambiguate between on-demand runtime normalization and after-fetch
runtime normalization
    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    39e6c63 View commit details
    Browse the repository at this point in the history

  2. canonical and pre-canonical clarifications

    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    a39a299 View commit details
    Browse the repository at this point in the history

  3. improve newRequestContext() docs

    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    0e98a96 View commit details
    Browse the repository at this point in the history

  4. improve render request handling docs

    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4932c7e View commit details
    Browse the repository at this point in the history

  5. introduce unit tests to see whether series are canonical... 

    ...at least for a couple different functions, and also for summarize in
the !alignToFrom case.
    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    f9b0ce5 View commit details
    Browse the repository at this point in the history

  6. summarize(): in !alignToFrom case, return output in canonical format 

    See #1811 for more details
Before, it was common for output to contain an extraneous point that
lies before 'from' (and wouldn't be rendered by Grafana in graph
panels), which made the output invalid.

This would result in trouble when

* combining such a series with another series
  (#1811)
* or when needing normalization
  (#1845)

This effectively slightly changes the output format, but is more robust.
    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e413585 View commit details
    Browse the repository at this point in the history

  7. refactor: isolate out "make pre-canonical" logic

    @Dieterbe
    Dieterbe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    47322f6 View commit details
    Browse the repository at this point in the history