This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
replace statsd[aemon] metrics with built-in metrics library #384
Closed
Closed
Changes from 35 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
8839ae0
remove metrics that are unused or are now created/used in other packages
Dieterbe 7fe099a
remove "github.com/raintank/met" and its deps from vendor folder
Dieterbe 8fd1ccc
WIP replace statsd[aemon] metrics with built-in metrics library
Dieterbe c49dfa8
new config for new metrics library
Dieterbe 9982b0b
update install/quickstart guide for new stats library
Dieterbe 21626d2
move instrumented_nsq to main repo
Dieterbe ee9ee4d
do metrics the new way
Dieterbe f86e60f
update metric prefix for a better namespace distinguished from statsd
Dieterbe 4eaa1eb
rework the metrics hierarchy
Dieterbe 5f4c8ab
do stats config setup via module
Dieterbe ab30abc
make each metric declare their mtype
Dieterbe 39f1e71
histogram & meter: track count, also as rate. clarify duration
Dieterbe 51b2e89
measure time spent calling into idx and tank (~backpressure)
Dieterbe dc415b9
clarify ok/fail metrics are for add operation
Dieterbe 7deaa16
fix dashboard
Dieterbe fbd141f
add docker env which makes testing of new stats easier
Dieterbe c05e99a
remove print
Dieterbe 9f03d59
improve metrics prefix
Dieterbe 7d6d152
also report this type of invalid metric
Dieterbe 2080c3c
reset registry in benches so adding new metrics works
Dieterbe ec47883
update metrics descriptions
Dieterbe 767502e
end2end test should use binary in build dir
Dieterbe 6bfae5f
set environment in docker config to docker-env
Dieterbe a03842a
docker-dev should use actual config file from dir
Dieterbe 6978d4b
fix end2end metric name
Dieterbe 0f9fc02
can now track metricsActive directly
Dieterbe 98e9678
simplify how we instantiate new stats
Dieterbe e8def85
better lock
Dieterbe 622e18f
better pressure visualization
Dieterbe 47cca8b
fix stats buffer-size option
Dieterbe 4c9fbc2
add metrics about stats itself
Dieterbe d40e06e
better default from
Dieterbe 5eac470
support calling Start and Stop over and over
Dieterbe 650d027
simplify outbound to graphite conn routine
Dieterbe 7b46143
on err, can bail out earlier + simplify a bit
Dieterbe f2cfaae
simplify
Dieterbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems outdated, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cleared this up on slack. but basically https://github.com/Dieterbe/metrics2docs is a bit simplistic, it can't parse the code very well, and as there are 2 places where we dynamically construct these metrics:
we need to add two comments for each metric here, and there needs to be an empty line between them because otherwise metrics2docs fails