-
Notifications
You must be signed in to change notification settings - Fork 105
no need to go get anything. since we use vendoring #385
Conversation
shaves off about 25s from circleci builds |
@@ -1,14 +1,12 @@ | |||
.PHONY: test bin docker | |||
default: | |||
$(MAKE) all | |||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like to have a test target. So if the scripts/test.sh doesnt exist, lets create it and have it run go vet
and go test -race
how is this? I think
it wants us to specify explicitly the keys in those fields, which makes everything soo verbose 👎 |
But fixing the code is outside the scope of this change so i have created a separate issue. |
@@ -2,13 +2,13 @@ | |||
default: | |||
$(MAKE) all | |||
test: | |||
bash -c "./scripts/test.sh $(TEST)" | |||
CGO_ENABLED=1 go test -v -race $(go list ./... | grep -v /vendor/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you enabling CGO, shouldn't it be disabled as is the case for building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ go test -v -race $(go list ./... | grep -v /vendor/) ⏎
go test: -race requires cgo; enable cgo by setting CGO_ENABLED=1
No description provided.