This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Issue #397 #398
Merged
Issue #397 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the caller knows what's going on. Also, no point adding an entry into ES or cassandra if it failed to add into the memory index
otherwise we accidentally add defs to DefsById and Add() will always think it's already in the tree even when it's not. So when you then remove the cause of a metricdef not being able to go into the tree as in #397, it would no longer add it. This also changes the behavior of the idx.memory.fail metric: it will now keep triggering for every attempt to add to the index which fails. This is more accurate. fix #397 - fix #399
woodsaj
approved these changes
Nov 17, 2016
| // by deleting one or more nodes in the tree, any defs that previously failed may now | ||
| // be able to be added. An easy way to support this is just reset this map and give them | ||
| // all a chance again | ||
| m.FailedDefs = make(map[string]error) |
There was a problem hiding this comment.
I am not sure this is the best approach. Ideally in future we will expose the Delete API to users. On a large multi tenant system we could potentially see a steady stream of deletes coming in.
But with that said, i dont have a better suggestion and this certainly solves the problem we have today.
|
i just manually did the experiment of #397 again and can confirm it works now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.