mt-index-cat #437
mt-index-cat #437
Conversation
raintank/inspect@eb8a87e note: * without the idx/cass package because we will work with MT's own * without cmd/mt-index-cat/compare.sh
| var from string | ||
| var maxAge string | ||
| var count bool | ||
|
|
There was a problem hiding this comment.
i use it to separate variables for flags from other internal vars
There was a problem hiding this comment.
i'll just move the interval var down to where its used
| flag.Usage = func() { | ||
| fmt.Println(os.Args[0]) | ||
| fmt.Printf("Usage:\n\n") | ||
| fmt.Printf(" inspect-idx [global config flags] <idxtype> [idx config flags] output \n\n") |
There was a problem hiding this comment.
shouldn't the name of the executable be mt-index-cat now?
| os.Exit(-1) | ||
| } | ||
|
|
||
| var show func(d schema.MetricDefinition) |
There was a problem hiding this comment.
I'd move this declaration down so it's right above the switch on line 99 where it gets used. Just to save the reader some scrolling.
| var found bool | ||
| for _, output := range outputs { | ||
| if last == output { | ||
| found = true |
There was a problem hiding this comment.
A break would stop the loop once and output is found.
| case "vegeta-render-patterns": | ||
| show = out.GetVegetaRenderPattern(addr, from) | ||
| default: | ||
| panic("this should never happen. we already validated the output type") |
There was a problem hiding this comment.
That's indeed never supposed to happen, and the message also doesn't provide much information, so why even having the default case?
Actually I'd probably type output func(schema.MetricDefinition) and build a map like map[string]output.
Or maybe to avoid unnecessary calls to external packages even like that:
type output func()(func(schema.MetricDefinition))
outputs["vegeta-render"] = func() (func(schema.MetricDefinition)) {return out.GetVegetaRender(addr, from)}
That way validation if a string is in the keys of the map and the map lookup to the right function both become simple and without any ambiguity.
There was a problem hiding this comment.
I also thought of this but it just gets a bit too complicated for my taste. especially as you need to know the values of addr and from, which you only get after parsing the args, so you either use closures which take those as args (extra complication) or you construct the map after you know the values, which means you can't get the list of the keys in the help message, so you still need a separate listing.
There was a problem hiding this comment.
I'd probably have gone for the closures because it still feels more "elegant" than having a default case that should never happen. But yeah, it's really more complicated and not important at all
| defs = idx.Load(defs) | ||
|
|
||
| for _, d := range defs { | ||
| if maxAgeInt != 0 && d.LastUpdate > time.Now().Unix()-maxAgeInt { |
There was a problem hiding this comment.
if maxAgeInt == 0 we do not need to enter this whole loop.
There was a problem hiding this comment.
actually this made me realize there's a bug here. if maxAgeInt is 0, it means we should show them all without filtering.
| var orgId int | ||
| var partition int32 | ||
| var lastupdate int64 | ||
| var interval int |
There was a problem hiding this comment.
if string type variables are consolidated on a single line then the int type ones could be on one line too
this tool aims to make it easy to see what's in the index, though the most common use is the vegeta output format which lets you generate queries to target different series on metrictank, so you can pipe the output into
vegeta attack