This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Better mt index migrate #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
suggested changes
Jan 6, 2017
| logLevel = flag.Int("log-level", 2, "log level. 0=TRACE|1=DEBUG|2=INFO|3=WARN|4=ERROR|5=CRITICAL|6=FATAL") | ||
| cassAddr = flag.String("cass-addr", "localhost", "Address of cassandra host.") | ||
| keyspace = flag.String("keyspace", "raintank", "Cassandra keyspace to use.") | ||
| partitionSchema = flag.String("partition-schema", "byOrg", "method used for paritioning metrics. (byOrg|bySeries)") |
There was a problem hiding this comment.
this should be "partitionScheme" to match tsdb-gw.
woodsaj
reviewed
Jan 6, 2017
| @@ -50,18 +50,18 @@ func main() { | |||
| log.Fatalf("failed to create cql session. %s", err) | |||
| } | |||
| wg.Add(1) | |||
| go writeDefs(session, defsChan, wg) | |||
| go writeDefs(session, defsChan, &wg) | |||
There was a problem hiding this comment.
In other tools, i have just made the waitGroup a package variable rather than passing it to the goroutines.
Dieterbe
force-pushed
the
better-mt-index-migrate
branch
from
e4272c2
to
cb9bf66
Compare
we need to fix the index schema in 0.7 before we publish a mt-index-migrate-06-to-07 binary. |
|
ah i see what you're saying. for you mt-index-migrate-06-to-07 implies it will work for 0.7 stable. meh ok I don't lean strongly either way. |
|
Once PR #465 is merged, this can be merged. |
|
@Dieterbe once the merge conflicts are resolved, this can be merged |
woodsaj
approved these changes
Jan 16, 2017
be clear about the version and what it does exactly. also rename partition-by to partition-scheme
taken from https://gist.github.com/woodsaj/148dc5659a08299623dd57ffb5b4064c with just a more updated help message
Dieterbe
force-pushed
the
better-mt-index-migrate
branch
from
20b188f
to
b96c0f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interestingly, the fixes in my 3rd commit undo changes that @woodsaj made between his original version of the tool and the last one he posted on gist. ?