mt-store-cat #458
mt-store-cat #458
Conversation
|
Would it be hard to modify |
|
it's a little involved, figuring out how to do it nicely.
So, the reason we don't support that yet, is more because I haven't figured out an elegant way to do it yet, rather then it being hard per se. |
| cassandraReadConcurrency = flag.Int("cassandra-read-concurrency", 20, "max number of concurrent reads to cassandra.") | ||
| //cassandraWriteConcurrency = flag.Int("cassandra-write-concurrency", 10, "max number of concurrent writes to cassandra.") | ||
| cassandraReadQueueSize = flag.Int("cassandra-read-queue-size", 100, "max number of outstanding reads before blocking. value doesn't matter much") | ||
| //cassandraWriteQueueSize = flag.Int("cassandra-write-queue-size", 100000, "write queue size per cassandra worker. should be large engough to hold all at least the total number of series expected, divided by how many workers you have") |
There was a problem hiding this comment.
should the commented ones be deleted if they're not needed before merging?
There was a problem hiding this comment.
i was wondering the same thing. this was my way of signifying that all options are the standard cassandra store options, except the commented out ones aren't relevant here.
| if nan { | ||
| fmt.Println("- ", time.Unix(int64(ts), 0).Format(tsFormat), "NAN") | ||
| } else { | ||
| fmt.Println("- ", time.Unix(int64(ts), 0).Format(tsFormat), val) |
There was a problem hiding this comment.
personally I'd think it's nicer to just assign something like a prefix variable in the if / else blocks which contains the - / > and, same for the val / "NAN", then remove the (almost) duplicate prints.
There was a problem hiding this comment.
I agree, but val and "NAN" are different types (float64 vs string) so can't do that here.
There was a problem hiding this comment.
they'll both end up being converted to strings eventually, no? so you could as well convert it to a string one step earlier than in the fmt.Println(). But if you don't want to nevermind, really doesn't matter much.
| // os.Exit(-1) | ||
| // } | ||
| // org = int(org64) | ||
| // query = flag.Arg(4) |
There was a problem hiding this comment.
i guess those are all future plans
|
LGTM |
here's a workflow: