This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix garbled output #524
Merged
fix garbled output #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while executing a template concurrently is OK, and writes to os.Stdout are atomic as well, we had a bug: Template.Execute does separate writes for each "step", i.e. each variable that needs to be printed, and the final newline. So even under a medium workload of 10kMsg/s occasionally the output would be garbled due to attributes and newlines being printed intermingled. We could probably have solved this without any locks: have the template do its complete execution into a temporary buffer, and then write the buffer (all at once) to stdout, which is atomic. But then you may have to worry about managing the temporary buffers. This is a simple solution that seems to work well.
Dieterbe
force-pushed
the
mt-kafka-mdm-sniff-garbled
branch
from
2181f0f
to
f479823
Compare
woodsaj
approved these changes
Feb 10, 2017
replay
reviewed
Feb 10, 2017
| @@ -20,6 +21,8 @@ import ( | |||
| var ( | |||
| confFile = flag.String("config", "/etc/raintank/metrictank.ini", "configuration file path") | |||
| format = flag.String("format", "{{.Part}} {{.OrgId}} {{.Id}} {{.Name}} {{.Metric}} {{.Interval}} {{.Value}} {{.Time}} {{.Unit}} {{.Mtype}} {{.Tags}}", "template to render the data with") | |||
|
|
|||
| stdoutLock = sync.Mutex{} | |||
There was a problem hiding this comment.
If i see that right mdm.Start(newInputPrinter(*format)) is never creating more than 1 instance of inputPrinter. So couldn't this lock be local to the inputPrinter struct? did you just make it package global in case something else wants to print?
There was a problem hiding this comment.
indeed, having it local to inputPrinter should also work fine.
But i don't see a strong reason to prefer it one way or another.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.