This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Lag monitor better calc #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* more accurate rate calculation. (don't round too early) * fix behavior for offset-commit-interval < 1s: if Store() is called again in under a second, previous code would update lastTs but return without setting rate since duration would round to 0. so many successive calls with <1s in between, even if they cover many seconds in aggregate would never lead to the rate being properly calculated. Now we still consider <1s not high-res enough to execute the calculation, but we only update the baseline when appropriate. the benefit now also is that this value can be tuned, instead of being implied through rounding.
Dieterbe
force-pushed
the
lag-monitor-better-calc
branch
from
bf3b227
to
5288120
Compare
woodsaj
approved these changes
Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if Store() is called again in under a second, previous code would update lastTs
but return without setting rate since duration would round to 0.
so many successive calls with <1s in between, even if they cover many seconds in aggregate
would never lead to the rate being properly calculated.
Now we still consider <1s not high-res enough to execute the
calculation, but we only update the baseline when appropriate.
the benefit now also is that this value can be tuned, instead of being implied through rounding.