This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Fix memory idx deletes #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
force-pushed
the
fixMemoryIdxDeletes
branch
from
7724b99
to
e2be2cc
Compare
Dieterbe
suggested changes
Feb 27, 2017
idx/memory/memory_test.go
Outdated
| series := []*schema.MetricData{ | ||
| { | ||
| Name: fmt.Sprintf("a.b.c"), | ||
| Metric: fmt.Sprintf("a.b.c"), |
There was a problem hiding this comment.
static names -> no need for the Sprintf calls
- fixes #552 - the index delete code was still assuming that nodes could only be branches or leafs and not both. - add unit tests to verify correct behaviour
woodsaj
force-pushed
the
fixMemoryIdxDeletes
branch
from
e2be2cc
to
c5dde9f
Compare
Dieterbe
approved these changes
Feb 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #552