This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Idx adds updates can only succeed #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 008737c any index add/update will always succeed, there's no possible error condition anymore.
Dieterbe
force-pushed
the
idx-adds-updates-can-only-succeed
branch
from
161175d
to
8ed6f77
Compare
|
That's gonna be the perfect merge conflict with #565 but looks good otherwise :) |
woodsaj
approved these changes
Mar 16, 2017
|
@replay sorry about the merge conflict. but it should be easy to resolve. I want to get this one in first so that the idx code is a bit cleaner to base the rest on top of. if it makes you feel any better I'll have to resolve conflicts too when i rebase my graphitey-consolidation branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.