This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Max datapoints per target #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
force-pushed
the
573-max-datapoints-rule
branch
from
bae2d31
to
f161557
Compare
woodsaj
force-pushed
the
573-max-datapoints-rule
branch
from
f161557
to
c1d8c18
Compare
- remove existing limits and replace with soft and hard limits - if a request exceeds the soft limit, lower resolution rollups will be used - if a request exceeds the hard limit it will be rejected.
woodsaj
approved these changes
Mar 29, 2017
Dieterbe
reviewed
Mar 29, 2017
| req.Archive = -1 | ||
| targets[req.Target] = struct{}{} | ||
| } | ||
| numTargets := uint32(len(targets)) |
There was a problem hiding this comment.
why not just len(reqs)? why build the temporary set?
There was a problem hiding this comment.
i think the idea is that there can be multiple requests with the same req.Target but in the response we'll only send each target once, so that's the count of unique targets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to limit the amount of data that gets sent out by Metrictank, to prevent the receiver from flooding it's memory when parsing the reply.
fixes #573