This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
ensure nodes can only connect to clusters with the same clusterName #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
reviewed
Apr 6, 2017
docs/config.md
Outdated
| @@ -226,6 +226,8 @@ net-max-open-requests = 100 | |||
|
|
|||
| ``` | |||
| [cluster] | |||
| # Unique name of the cluster. | |||
There was a problem hiding this comment.
Might want to mention in the comment that this name is used to make sure that only metrictanks with the same cluster name connect to each other. Otherwise it's kind of ambiguous what this setting is for.
replay
reviewed
Apr 6, 2017
| Members []cluster.Node `json:"members"` | ||
| ClusterName string `json:"clusterName"` | ||
| NodeName string `json:"nodeName"` | ||
| Members []cluster.Node `json:"members"` |
There was a problem hiding this comment.
I'm assuming that currently the only purpose of this is to make the name queryable via /cluster
- fixes #596 - add cluster "name" setting to the config - use the clusterName as the security key with memberlist. This will prevent nodes from other clusters from connecting. - expose the cluster name in the /cluster api method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will prevent nodes from other clusters from connecting.