Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

refactor pickle support #616

Merged
merged 1 commit into from
Apr 26, 2017
Merged

refactor pickle support #616

merged 1 commit into from
Apr 26, 2017

Conversation

woodsaj
Copy link
Member

@woodsaj woodsaj commented Apr 25, 2017

  • use a "Picklable" interface that structs can implement.
  • set datapoints to pickle.None type with the points are null (NaN)

fixes #615

- use a "Picklable" interface that structs can implement.
- set datapoints to pickle.None type with the points are null (NaN)
@woodsaj woodsaj requested review from Dieterbe and replay April 25, 2017 22:30
@Dieterbe
Copy link
Contributor

benchmarks look about the same (use grain of salt, benchmarks run on noisy cloud environment)

BEFORE (master)

BenchmarkHttpRespPickleEmptySeries-2                   	  300000	      4893 ns/op
BenchmarkHttpRespPickleEmptySeriesNeedsEscaping-2      	  300000	      4899 ns/op
BenchmarkHttpRespPickleIntegers-2                      	   10000	    115529 ns/op	 103.87 MB/s
BenchmarkHttpRespPickleFloats-2                        	   10000	    117172 ns/op	 102.41 MB/s
BenchmarkHttpRespPickleNulls-2                         	   10000	    115710 ns/op	 103.71 MB/s
BenchmarkConvertSeriesToPickleFormat10k-2              	   50000	     29210 ns/op	4108.18 MB/s

AFTER (this branch)

BenchmarkHttpRespPickleEmptySeries-2                   	  500000	      3713 ns/op
BenchmarkHttpRespPickleEmptySeriesNeedsEscaping-2      	  500000	      3727 ns/op
BenchmarkHttpRespPickleIntegers-2                      	   10000	    149439 ns/op	  80.30 MB/s
BenchmarkHttpRespPickleFloats-2                        	   10000	    149255 ns/op	  80.40 MB/s
BenchmarkHttpRespPickleNulls-2                         	   20000	     97434 ns/op	 123.16 MB/s

@woodsaj woodsaj merged commit 417d889 into master Apr 26, 2017
@woodsaj woodsaj deleted the pickleUpdate branch April 26, 2017 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphite-web doesnt consider null values to be null
2 participants