This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
add new mt-replicator tool #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
suggested changes
Jun 1, 2017
| return | ||
| } | ||
|
|
||
| func (r *MetricsReplicator) Start() { |
There was a problem hiding this comment.
i would reorder the code. after the constructor put Start, then Stop, then consume and flush (make the latter two non-exported), the order seems pretty arbitrary now, I think it's generally a good idea to put the main calleable logic first and helper functions below them
|
|
||
| var ( | ||
| producerBatchSize = flag.Int("batch-size", 10000, "number of metrics to send in each batch.") | ||
| destinationUrl = flag.String("destination-url", "http://localhost/metrics", "tsdb-gw address to send metrics to") |
There was a problem hiding this comment.
when i run gometalinter I see:
metrics.go:23:2:warning: var destinationUrl should be destinationURL (golint)
metrics.go:27:2:warning: var clientId should be clientID (golint)
see https://github.com/golang/go/wiki/CodeReviewComments#initialisms
added 3 commits
June 30, 2017 05:35
When replicating between clusters in different networks it is not always easy to push from one kafka to another due to Kafka requiring that publishers send to the configured "advertised_addr" which probably isnt internet facing. This new tool consumes from a local kafka cluster and publishes data to a remote tsdb-gw server.
woodsaj
force-pushed
the
mt-replicator-via-tsdb
branch
from
8509fd1
to
151c262
Compare
|
@Dieterbe can we get this merged now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replicating between clusters in different networks it is not
always easy to push from one kafka to another due to Kafka
requiring that publishers send to the configured "advertised_addr"
which probably isnt internet facing. This new tool consumes from
a local kafka cluster and publishes data to a remote tsdb-gw server.