This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fixes for expr naming #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
changed the title
previous approach assumed the same queryPattern was never specified multiple times, which was wrong. this approach is also simpler and faster
woodsaj
suggested changes
Jun 24, 2017
expr/NOTES
Outdated
| it follows that the output returned by plan.Run must always use Target attribute to show the proper name, and that any processing functions thus must set that attribute properly. | ||
| when requesting series directly, we want to show the target (to uniquely identify each series), not the queryPattern | ||
| thus the output returned by plan.Run must always use Target attribute to show the proper name | ||
| thus any processing functions thus must set that attribute properly. |
woodsaj
approved these changes
Jun 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.