This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Adds an endpoint to post cluster peers to #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
reviewed
Jul 6, 2017
api/cluster.go
Outdated
| @@ -51,6 +51,41 @@ func (s *Server) getClusterStatus(ctx *middleware.Context) { | |||
| response.Write(ctx, response.NewJson(200, status, "")) | |||
| } | |||
|
|
|||
| func (s *Server) postClusterMembers(ctx *middleware.Context, req models.ClusterMembers) { | |||
| memberNames := make(map[string]struct{}) | |||
| toJoin := make([]string, 0) | |||
There was a problem hiding this comment.
you don't need to pre-allocate slices. just declaring them is enough. len, range, etc will work fine. (annoyingly the same can't be said about maps)
replay
force-pushed
the
cluster_peer_route
branch
from
9e31ebd
to
f505246
Compare
|
LGTM now. @replay shall i merge? |
|
yes please @Dieterbe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.