This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
support more from/to specifications, honor timezone controls. #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by pulling in latest `dur` library which nows needs to be passed in an explicit timezone. It used to use time.Local which we default to now as well, but we now allow controlling timezone via configuration and `tz` argument in render requests, just like graphite. (note: graphite defaults to Chicago which seems rather silly) fix #673 fix #681
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows a bunch more from/to specifications like "now-3h", "midnight" etc. see raintank/dur#1
latest
durlibrary nows needs to be passed inan explicit timezone. It used to use time.Local which we default
to now as well, but we now allow controlling timezone via configuration
and
tzargument in render requests, just like graphite.(note: graphite defaults to Chicago which seems rather silly)
fix #673
fix #681
I tested setting custom TZ's via config and via
tzarg and it all seems to work fine. though there is one weird thing: when you request a non existing timezone, you get an error like "open /home/dieter/code/go/lib/time/zoneinfo.zip: no such file or directory" which is a misleading error