Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

update TWCS settings #690

Merged
merged 1 commit into from
Jul 17, 2017
Merged

update TWCS settings #690

merged 1 commit into from
Jul 17, 2017

Conversation

woodsaj
Copy link
Member

@woodsaj woodsaj commented Jul 14, 2017

  • need to explicitly defined the tombstone settings, even though
    they are set to defaults. If they are not defined, TWCS wont
    ever delete fully expired sstables

update TWCS settings
04f566b 
- need to explicitly defined the tombstone settings, even though
  they are set to defaults.  If they are not defined, TWCS wont
  ever delete fully expired sstables
@woodsaj woodsaj requested review from Dieterbe and replay July 14, 2017 16:14
replay
replay approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find

@woodsaj woodsaj merged commit 8d7570a into master Jul 17, 2017
@woodsaj woodsaj deleted the twcsSettings branch July 17, 2017 07:22
@Dieterbe
Copy link
Contributor

@woodsaj @replay whenever we change the hardcoded default schema we must also update the schema in the docs. (ideally of course we would generate docs from what's hardcoded)

@woodsaj
Copy link
Member Author

woodsaj commented Jul 17, 2017

@Dieter The current docs dont make sense as the metric tables are dynamically generated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@replay replay replay approved these changes

@Dieterbe Dieterbe Awaiting requested review from Dieterbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodsaj @Dieterbe @replay