This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
this might fix an OOM problem in cache.searchForward #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
maybe-oom-fix
branch
5 times, most recently
from
22558a8
to
b9d4df9
Compare
with the following symptoms:
```
Showing nodes accounting for 8385.53MB, 98.50% of 8513.19MB total
Dropped 217 nodes (cum <= 42.57MB)
Showing top 30 nodes out of 60
flat flat% sum% cum cum%
5171.26MB 60.74% 60.74% 5173.26MB 60.77% github.com/raintank/metrictank/mdata/cache.(*CCacheMetric).searchForward /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/mdata/cache/ccache_metric.go
719.10MB 8.45% 69.19% 986.11MB 11.58% github.com/raintank/metrictank/mdata.NewAggMetric /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/mdata/aggmetric.go
714.62MB 8.39% 77.59% 714.62MB 8.39% runtime.rawstringtmp /usr/local/go/src/runtime/string.go
616.55MB 7.24% 84.83% 617.55MB 7.25% github.com/raintank/metrictank/mdata/chunk.New /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/mdata/chunk/chunk.go
436.67MB 5.13% 89.96% 436.67MB 5.13% github.com/raintank/metrictank/vendor/github.com/dgryski/go-tsz.(*bstream).writeBits /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/vendor/github.com/dgryski/go-tsz/bstream.go
...
. . 194: // add all consecutive chunks to search results, starting at the one containing "from"
. . 195: for ; ts != 0; ts = mc.chunks[ts].Next {
. 2MB 196: log.Debug("CCacheMetric searchForward: forward search adds chunk ts %d to start", ts)
5.05GB 5.05GB 197: res.Start = append(res.Start, mc.chunks[ts].Itgen)
...
```
Dieterbe
changed the title
|
If we would end up in a situation where |
|
so I think deploying it wouldn't hurt, I hope that it won't detect such an inconsistency |
replay
approved these changes
Jul 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.