This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
more tracing #713
Merged
more tracing #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
tracing-v2
branch
2 times, most recently
from
36553d1
to
2aeeb51
Compare
* add more spans to get more insights: - getSeries (minus consolidate/divide when needed, itersToPoints, Fix()) - GetSeriesAggMetric (ringbuffer) - CCache.Search (chunkcache) - CassandraStore.SearchTable (store) * more stats about render: eg oldest_in_ring, points_fetch, points_return * use utility functions to aid with: - creating new spans - logging errors properly. we were abusing "error.kind"
This only covered the cases where we can call WriteErr explicitly, and obviously doesn't work e.g. when bind.Bind returns an error This reverts commit d90a3a6.
in a way that works with our own errors, as well as those emitted by standard/3rd party middlewares like bind.Bind error=true is set for internal errors, not for users doing invalid requests and so on.
Dieterbe
requested review from
replay and
woodsaj
and removed request for
replay
replay
reviewed
Aug 26, 2017
api/dataprocessor.go
Outdated
| res := s.getSeries(ctx) | ||
| res.Points = append(s.itersToPoints(ctx, res.Iters), res.Points...) | ||
| func (s *Server) getSeriesFixed(ctx context.Context, req models.Req, consolidator consolidation.Consolidator) []schema.Point { | ||
| rctx := newRequestContext(&req, consolidator) |
There was a problem hiding this comment.
i think it might be nicer to just make ctx an attribute of rctx, otherwise having two contexts around can be confusing.
replay
reviewed
Aug 26, 2017
mdata/cache/ccache.go
Outdated
| @@ -131,7 +141,9 @@ func (c *CCache) evict(target *accnt.EvictTarget) { | |||
| } | |||
| } | |||
|
|
|||
| func (c *CCache) Search(metric string, from, until uint32) *CCSearchResult { | |||
| func (c *CCache) Search(ctx context.Context, metric string, from, until uint32) *CCSearchResult { | |||
| ctx, span := tracing.NewSpan(ctx, c.tracer, "CCache.Search") | |||
There was a problem hiding this comment.
I'm surprised the compiler doesn't complain about this ctx being unused, I assume that's probably because it's a recycled name, but anyway it's unused
replay
reviewed
Aug 26, 2017
mdata/store_cassandra.go
Outdated
| } | ||
|
|
||
| // Basic search of cassandra in given table | ||
| // start inclusive, end exclusive | ||
| func (c *CassandraStore) SearchTable(key, table string, start, end uint32) ([]chunk.IterGen, error) { | ||
| func (c *CassandraStore) SearchTable(ctx context.Context, key, table string, start, end uint32) ([]chunk.IterGen, error) { | ||
| ctx, span := tracing.NewSpan(ctx, c.tracer, "CassandraStore.SearchTable") |
There was a problem hiding this comment.
actually that probably really doesn't matter much since that memory of ctx is already allocated anyway. the only difference is that by using a _ instead of assigning to ctx we could save a few ops for overwriting that memory, which is probably not significant
|
PTAL @replay |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg oldest_in_ring, points_fetch, points_return