This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
make the dashboard multi-instance capable #722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my vision (this is basically how i've been doing things since forever, but never really documented it):
this time around, things were more interesting, as we have 2 internal dashboards, one per-instance, and one for multi-instance, which had some changes, but was started from an older 0.7.0-beta1 dashboard, so it also was missing a bunch of stuff.
i have done step 4 which was a bit more work now, but my idea is from now on we can use 1 dashboard that can serve both the single-instance, as well as multi-instance use cases.
it means making a few compromises here and there (in particular, making the legend useful both for many different instances as well as 1 specific instance, means it won't always look optimal for both), but I think it's worth it.
you can check out metrictank-0-7-4 in our internal monitoring to see it in action.
i already removed our older single-instance dashboard and plan to remove the metrictank-0-7-0-beta1-k8s-cluster one as well.